|
|
You're in the
sql server programming
group:DateTime in an SP
sql server programming:
try
SELECT @sdate = '20030315' what datatype is ShowDate? You need to convert @sdate to a character string in the correct format AND (ShowDate = ''' + convert(varchar(8),@sdate,112) + ''') see convert in bol for the styles.
I am trying to specify a date as a criteria in an SQL statement used within
an SP. The date is an input parameter. When I run the SP I get an error "Syntax error converting datetime from character string." The declaration shows: DECLARE @sdate datetime DECLARE @stype char(2) DECLARE @regyear char(4) SELECT @sdate = '03/15/2003' SELECT @stype = 'SC' SELECT @regyear = '2003' And the relevant part of the SQL statement is: AND (ShowDate = ''' + @sdate + ''') <= those are 3 single quotes What is the correct syntax within an SP for datetime? -- ------------------------------------ Wayne Wengert wayne@wengert.org
[quoted text, click to view]
>> So to compare a date within the SQL in an SP it can only be done by converting the date to a string?No but you seemed to be trying to create dynamic sql for the query. select * from tbl where ShowDate = @sdate Should work as you have smalldatetime and datetime - but
The ShowDate is a SmallDateTime value. I tried CASTing the @sdate but that
didn't work. So to compare a date within the SQL in an SP it can only be done by converting the date to a string? That sure seems weird. I'll go to bol to see if I can figure this out. Wayne [quoted text, click to view] "Nigel Rivett" <sqlnr@hotmail.com> wrote in message news:052701c3a032$ca97f0b0$a401280a@phx.gbl... > try > SELECT @sdate = '20030315' > > what datatype is ShowDate? > > You need to convert @sdate to a character string in the > correct format > > AND (ShowDate = ''' + convert(varchar(8),@sdate,112) + ''') > > see convert in bol for the styles. >
Wayne,
If the sql statement your referring to is not a dynamic one (exec or sp_executesql) then you don't need quotes at all if the variable is already a datetime or smalldatetime. -- Andrew J. Kelly SQL Server MVP [quoted text, click to view] "Wayne Wengert" <wayneFaked@wengert.com> wrote in message news:%23ihUcTDoDHA.1672@TK2MSFTNGP09.phx.gbl... > The ShowDate is a SmallDateTime value. I tried CASTing the @sdate but that > didn't work. > > So to compare a date within the SQL in an SP it can only be done by > converting the date to a string? That sure seems weird. I'll go to bol to > see if I can figure this out. > > Wayne > > "Nigel Rivett" <sqlnr@hotmail.com> wrote in message > news:052701c3a032$ca97f0b0$a401280a@phx.gbl... > > try > > SELECT @sdate = '20030315' > > > > what datatype is ShowDate? > > > > You need to convert @sdate to a character string in the > > correct format > > > > AND (ShowDate = ''' + convert(varchar(8),@sdate,112) + ''') > > > > see convert in bol for the styles. > > > >
Spotted your earlier post and you are indeed using dynamic sql.
Try this - I have reformatted to make it easier - if it loses the formatting insert tabs so that all the statements line up select @sql = 'SELECT DISTINCT ShowName, ShowTable, CircuitID, ShowDate, ShowType, RegCode, PorF' select @sql = @sql + ' FROM ' + @sglpnltable select @sql = @sql + ' WHERE CircuitID = 0' + select @sql = @sql + ' AND ShowDate = ''' + convert(varchar(8),@sdate,112) + '''' select @sql = @sql + ' AND ShowType = ''' + @stype +'''' select @sql = @sql + ' UNION ' select @sql = @sql + 'SELECT DISTINCT ShowName, ShowTable, CircuitID, ShowDate, ShowType, RegCode, PorF' select @sql = @sql + ' FROM ' + @dblpnltable select @sql = @sql + ' WHERE CircuitID = 0)' select @sql = @sql + ' AND ShowDate = '''+ convert(varchar(8),@sdate,112) + '''' select @sql = @sql + ' AND ShowType = ''' + @stype + '''' select @sql = @sql + ' Order By RegCode' Print (@sql) EXEC (@sql) Nigel Rivett (SQL Server MVP) www.nigelrivett.net *** Sent via Developersdex http://www.developersdex.com ***
dynamic sql is when you create a string and execute it
exec ('select * from mytbl') It is used when you need to build up an sql statement declare @sql varchar(1000) select @sql = 'select * from ' + @tblname exec(@sql) which is why it is called dynamic. Your original question had AND (ShowDate = ''' + @sdate + ''') <= those are 3 single quotes which looks like you are building a string for the sql statement - hence my convertion to a character string for the date if not select * from tbl where .... and ShowDate = @sdate and ... Nigel Rivett (SQL Server MVP) www.nigelrivett.net *** Sent via Developersdex http://www.developersdex.com ***
Andrew;
Thanks for the response. I am confused on exactly what "dynamic sql" means (I'll do more reading in bol) so I'm not sure what I have. The SQL is within an SP that is called from an ASP page using EXEC. Wayne [quoted text, click to view] "Andrew J. Kelly" <sqlmvpnooospam@shadhawk.com> wrote in message news:u$ERShDoDHA.2268@TK2MSFTNGP12.phx.gbl... > Wayne, > > If the sql statement your referring to is not a dynamic one (exec or > sp_executesql) then you don't need quotes at all if the variable is already > a datetime or smalldatetime. > > -- > > Andrew J. Kelly > SQL Server MVP > > > "Wayne Wengert" <wayneFaked@wengert.com> wrote in message > news:%23ihUcTDoDHA.1672@TK2MSFTNGP09.phx.gbl... > > The ShowDate is a SmallDateTime value. I tried CASTing the @sdate but that > > didn't work. > > > > So to compare a date within the SQL in an SP it can only be done by > > converting the date to a string? That sure seems weird. I'll go to bol to > > see if I can figure this out. > > > > Wayne > > > > "Nigel Rivett" <sqlnr@hotmail.com> wrote in message > > news:052701c3a032$ca97f0b0$a401280a@phx.gbl... > > > try > > > SELECT @sdate = '20030315' > > > > > > what datatype is ShowDate? > > > > > > You need to convert @sdate to a character string in the > > > correct format > > > > > > AND (ShowDate = ''' + convert(varchar(8),@sdate,112) + ''') > > > > > > see convert in bol for the styles. > > > > > > > > >
Nigel;
Thanks for the responses. I got it working but I need to understand this better so I'll do more looking in my books and bol Appreciate the education Wayne [quoted text, click to view] "Nigel Rivett" <sqlnr@hotmail.com> wrote in message news:%23DUhP4IoDHA.1020@TK2MSFTNGP09.phx.gbl... > dynamic sql is when you create a string and execute it > > exec ('select * from mytbl') > > It is used when you need to build up an sql statement > declare @sql varchar(1000) > select @sql = 'select * from ' + @tblname > exec(@sql) > which is why it is called dynamic. > > Your original question had > > AND (ShowDate = ''' + @sdate + ''') <= those are 3 single quotes > > which looks like you are building a string for the sql statement - hence > my convertion to a character string for the date > > if not > > select * > from tbl > where .... > and ShowDate = @sdate > and ... > > > Nigel Rivett (SQL Server MVP) > www.nigelrivett.net > > *** Sent via Developersdex http://www.developersdex.com *** > Don't just participate in USENET...get rewarded for it!
Try using
SELECT @sdate = CAST('03/15/2003' AS DATETIME) [quoted text, click to view] "Wayne Wengert" <wayneFaked@wengert.com> wrote in message news:%23uHefEDoDHA.1408@TK2MSFTNGP11.phx.gbl... > I am trying to specify a date as a criteria in an SQL statement used within > an SP. The date is an input parameter. When I run the SP I get an error > "Syntax error converting datetime from character string." > > The declaration shows: > DECLARE @sdate datetime > DECLARE @stype char(2) > DECLARE @regyear char(4) > SELECT @sdate = '03/15/2003' > SELECT @stype = 'SC' > SELECT @regyear = '2003' > > And the relevant part of the SQL statement is: > AND (ShowDate = ''' + @sdate + ''') <= those are 3 single quotes > > What is the correct syntax within an SP for datetime? > > -- > ------------------------------------ > Wayne Wengert > wayne@wengert.org > >
Don't see what you're looking for? Try a search.
|
January 2003
March 2003
April 2003
May 2003
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
April 2008
| home · blog · groups | Questions? Comments? Contact the dn |