| Groups | Blog | Home |
sql server programming : SQL syntax help needed
another table. Something like this (using Select to see what the query will pull up) Running SQL Server 7 select * from startstop_dictation_log s Join Accession a ON (s.Accession_no = a.Accession_no) Where a.Status_Final = 'Y' The problem is that the connecting fields of the join statement have dissimilar data. s.Accession_no stores the accession numbers like this: S-03-00001 a.Accession_no stores the accession numbers like this: SCS-03-00001 I tried something like: select * from startstop_dictation_log s Join Accession a ON (Select Case Left(s.Accession_no,1) When 'S' Then 'SC'+ s.Accession_no When 'H' Then 'SC'+ s.Accession_no When 'A' Then 'SC'+ s.Accession_no When 'N' Then 'NCG'+ Right(s.Accession_no,9) = a.Accession_no) Where a.Status_Final = 'Y' Syntax is not right. I will probably put this into a stored proc. What do you guys think? Buddy G.
Thanks,
Doesn't "Delete s" refer to the entire table? I wanted to only delete rows where the accession number has been finalized. Buddy G [quoted text, click to view] "Jacco Schalkwijk" <NOSPAMjaccos@eurostop.co.uk> wrote in message news:uzoxOqoUDHA.2204@TK2MSFTNGP10.phx.gbl... > Hi Buddy, > > Try the following (untested, may contain typos): > > DELETE s > FROM startstop_dictation_log s > INNER JOIN Accession a > ON a.Accession_no = > CASE LEFT(s.Accession_no,1) > When 'S' Then 'SC'+ s.Accession_no > When 'H' Then 'SC'+ s.Accession_no > When 'A' Then 'SC'+ s.Accession_no > When 'N' Then 'NCG'+ Right(s.Accession_no,9) > END > Where a.Status_Final = 'Y' > > -- > Jacco Schalkwijk MCDBA, MCSD, MCSE > Database Administrator > Eurostop Ltd. > > > "Buddy G" <Buddy at gcsbend dot com> wrote in message > news:e23myOnUDHA.424@TK2MSFTNGP11.phx.gbl... > > I want to delete rows in a table based upon when status_final is true in > > another table. > > Something like this (using Select to see what the query will pull up) > > Running SQL Server 7 > > > > select * from startstop_dictation_log s > > Join Accession a ON (s.Accession_no = a.Accession_no) > > Where a.Status_Final = 'Y' > > > > The problem is that the connecting fields of the join statement have > > dissimilar data. > > s.Accession_no stores the accession numbers like this: S-03-00001 > > a.Accession_no stores the accession numbers like this: SCS-03-00001 > > > > I tried something like: > > select * from startstop_dictation_log s > > Join Accession a ON (Select Case Left(s.Accession_no,1) > > When 'S' Then 'SC'+ s.Accession_no > > When 'H' Then 'SC'+ s.Accession_no > > When 'A' Then 'SC'+ s.Accession_no > > When 'N' Then 'NCG'+ Right(s.Accession_no,9) = a.Accession_no) > > Where a.Status_Final = 'Y' > > > > Syntax is not right. > > > > I will probably put this into a stored proc. What do you guys think? > > > > Buddy G. > > > > > >
Hi Buddy,
Try the following (untested, may contain typos): DELETE s FROM startstop_dictation_log s INNER JOIN Accession a ON a.Accession_no = CASE LEFT(s.Accession_no,1) When 'S' Then 'SC'+ s.Accession_no When 'H' Then 'SC'+ s.Accession_no When 'A' Then 'SC'+ s.Accession_no When 'N' Then 'NCG'+ Right(s.Accession_no,9) END Where a.Status_Final = 'Y' -- Jacco Schalkwijk MCDBA, MCSD, MCSE Database Administrator Eurostop Ltd. [quoted text, click to view] "Buddy G" <Buddy at gcsbend dot com> wrote in message news:e23myOnUDHA.424@TK2MSFTNGP11.phx.gbl... > I want to delete rows in a table based upon when status_final is true in > another table. > Something like this (using Select to see what the query will pull up) > Running SQL Server 7 > > select * from startstop_dictation_log s > Join Accession a ON (s.Accession_no = a.Accession_no) > Where a.Status_Final = 'Y' > > The problem is that the connecting fields of the join statement have > dissimilar data. > s.Accession_no stores the accession numbers like this: S-03-00001 > a.Accession_no stores the accession numbers like this: SCS-03-00001 > > I tried something like: > select * from startstop_dictation_log s > Join Accession a ON (Select Case Left(s.Accession_no,1) > When 'S' Then 'SC'+ s.Accession_no > When 'H' Then 'SC'+ s.Accession_no > When 'A' Then 'SC'+ s.Accession_no > When 'N' Then 'NCG'+ Right(s.Accession_no,9) = a.Accession_no) > Where a.Status_Final = 'Y' > > Syntax is not right. > > I will probably put this into a stored proc. What do you guys think? > > Buddy G. > >
[quoted text, click to view]
>> I want to delete rows in a table based upon when status_final is 'Y' in another table. <<DELETE FROM Startstop_Dictation_Log WHERE EXISTS (SELECT * FROM Accession AS A1 WHERE A1.status_final = 'Y' AND A1.accession_no = CASE SUBSTRING(Startstop_Dictation_Log.accession_no, 1, 1) WHEN 'S' THEN 'SC'+ Startstop_Dictation_Log.accession_no WHEN 'H' THEN 'SC'+ Startstop_Dictation_Log.accession_no WHEN 'A' THEN 'SC'+ Startstop_Dictation_Log.accession_no WHEN 'N' THEN 'NCG'+ RIGHT(Startstop_Dictation_Log.accession_no, 9) END); But this is a really bad situation in the data model. One minute you are claim that the accession_no data element is used in both startstop_dictation_log and the Accessions table; fine. But then you have a different syntax for the same value in those two locations. This needs to be cleaned up. --CELKO-- =========================== Please post DDL, so that people do not have to guess what the keys, constraints, Declarative Referential Integrity, datatypes, etc. in your schema are. *** Sent via Developersdex http://www.developersdex.com ***
Yes, it does need a cleanup. This is the result of blending two different
systems into one, but I can modify the StartStop table schema and some scripts to fix this - eventually. I tried your query based on WHERE EXISTS and also the one from Jacco Based on the INNER JOIN and I get different results. Also, the case WHEN 'N' THEN 'NGC'+ RIGHT(Startstop_Dictation_Log.accession_no, 9) does not return anything. It should convert N-03-00001 to NGC-03-00001 but it does not work. I checked and there are matching records in the two tables. Any Ideas? Thanks for your reply, Buddy G [quoted text, click to view] "Joe Celko" <celko@northface.edu> wrote in message news:Or7p9CtUDHA.1748@TK2MSFTNGP12.phx.gbl... > >> I want to delete rows in a table based upon when status_final is 'Y' > in another table. << > > DELETE FROM Startstop_Dictation_Log > WHERE EXISTS > (SELECT * > FROM Accession AS A1 > WHERE A1.status_final = 'Y' > AND A1.accession_no = > CASE SUBSTRING(Startstop_Dictation_Log.accession_no, 1, 1) > WHEN 'S' THEN 'SC'+ Startstop_Dictation_Log.accession_no > WHEN 'H' THEN 'SC'+ Startstop_Dictation_Log.accession_no > WHEN 'A' THEN 'SC'+ Startstop_Dictation_Log.accession_no > WHEN 'N' THEN 'NCG'+ RIGHT(Startstop_Dictation_Log.accession_no, > 9) > END); > > But this is a really bad situation in the data model. One minute you > are claim that the accession_no data element is used in both > startstop_dictation_log and the Accessions table; fine. But then you > have a different syntax for the same value in those two locations. This > needs to be cleaned up. > > --CELKO-- > =========================== > Please post DDL, so that people do not have to guess what the keys, > constraints, Declarative Referential Integrity, datatypes, etc. in your > schema are. > > *** Sent via Developersdex http://www.developersdex.com *** > Don't just participate in USENET...get rewarded for it!
[quoted text, click to view]
>> It should convert N-03-00001 to NGC-03-00001 but it does not work. << I jujst copied what you gave. Would this do it? Try shortening the prefixes on the longer string instead of extending the shorter string. DELETE FROM Startstop_Dictation_Log WHERE EXISTS (SELECT * FROM Accession AS A1 WHERE A1.status_final = 'Y' AND A1.accession_no = REPLACE( REPLACE(Startstop_Dictation_Log.accession_no, 'SC',''), 'GC-', '-'); --CELKO-- =========================== Please post DDL, so that people do not have to guess what the keys, constraints, Declarative Referential Integrity, datatypes, etc. in your schema are. *** Sent via Developersdex http://www.developersdex.com ***
Hi Buddy,
The number of rows that is deleted is limited by the join, the entire table won't be deleted. The difference between Joe's and my results is because Joe looks at the left most character of Accession.Accession_no and I look at the left most character of startstop_dictation_log.Accession_no. I think from your narrative that my solution is correct, but if you can post scripts to create the tables (easy to do from Enterprise Manager) and to insert sample data (use this script here: http://vyaskn.tripod.com/code.htm#inserts) and the results you expect we can test it out. Jacco [quoted text, click to view] "Buddy G" <Buddy at gcsbend dot com> wrote in message news:eU3kEssUDHA.1052@TK2MSFTNGP09.phx.gbl... > Thanks, > Doesn't "Delete s" refer to the entire table? I wanted to only delete rows > where the accession number has been finalized. > > Buddy G > > "Jacco Schalkwijk" <NOSPAMjaccos@eurostop.co.uk> wrote in message > news:uzoxOqoUDHA.2204@TK2MSFTNGP10.phx.gbl... > > Hi Buddy, > > > > Try the following (untested, may contain typos): > > > > DELETE s > > FROM startstop_dictation_log s > > INNER JOIN Accession a > > ON a.Accession_no = > > CASE LEFT(s.Accession_no,1) > > When 'S' Then 'SC'+ s.Accession_no > > When 'H' Then 'SC'+ s.Accession_no > > When 'A' Then 'SC'+ s.Accession_no > > When 'N' Then 'NCG'+ Right(s.Accession_no,9) > > END > > Where a.Status_Final = 'Y' > > > > -- > > Jacco Schalkwijk MCDBA, MCSD, MCSE > > Database Administrator > > Eurostop Ltd. > > > > > > "Buddy G" <Buddy at gcsbend dot com> wrote in message > > news:e23myOnUDHA.424@TK2MSFTNGP11.phx.gbl... > > > I want to delete rows in a table based upon when status_final is true in > > > another table. > > > Something like this (using Select to see what the query will pull up) > > > Running SQL Server 7 > > > > > > select * from startstop_dictation_log s > > > Join Accession a ON (s.Accession_no = a.Accession_no) > > > Where a.Status_Final = 'Y' > > > > > > The problem is that the connecting fields of the join statement have > > > dissimilar data. > > > s.Accession_no stores the accession numbers like this: S-03-00001 > > > a.Accession_no stores the accession numbers like this: SCS-03-00001 > > > > > > I tried something like: > > > select * from startstop_dictation_log s > > > Join Accession a ON (Select Case Left(s.Accession_no,1) > > > When 'S' Then 'SC'+ s.Accession_no > > > When 'H' Then 'SC'+ s.Accession_no > > > When 'A' Then 'SC'+ s.Accession_no > > > When 'N' Then 'NCG'+ Right(s.Accession_no,9) = a.Accession_no) > > > Where a.Status_Final = 'Y' > > > > > > Syntax is not right. > > > > > > I will probably put this into a stored proc. What do you guys think? > > > > > > Buddy G. > > > > > > > > > > > >
Many thanks to Jacco and Joe!
I was never able to figure out why "When 'N' Then 'NGC'+ Right(s.Accession_no,9)" did not work, but using REPLACE (s.Accession_no,N,NGC) did work. However, I took Joe's advice and fixed the tables and code so that both systems use the same case type prefix, making the original query into a simple join. Works good now. Buddy G. [quoted text, click to view] "Joe Celko" <celko@northface.edu> wrote in message news:O5hBsGuUDHA.2364@TK2MSFTNGP09.phx.gbl... > >> It should convert N-03-00001 to NGC-03-00001 but it does not work. << > > I jujst copied what you gave. Would this do it? Try shortening the > prefixes on the longer string instead of extending the shorter string. > > DELETE FROM Startstop_Dictation_Log > WHERE EXISTS > (SELECT * > FROM Accession AS A1 > WHERE A1.status_final = 'Y' > AND A1.accession_no = > REPLACE( > REPLACE(Startstop_Dictation_Log.accession_no, 'SC',''), > 'GC-', '-'); > > --CELKO-- > =========================== > Please post DDL, so that people do not have to guess what the keys, > constraints, Declarative Referential Integrity, datatypes, etc. in your > schema are. > > *** Sent via Developersdex http://www.developersdex.com *** > Don't just participate in USENET...get rewarded for it!
Don't see what you're looking for? Try a search.
|
January 2003
March 2003
April 2003
May 2003
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
April 2008
August 2008
| home · blog · groups | Questions? Comments? Contact the dn |