| Groups | Blog | Home |
sql server programming : Stored procedure always returns NULL in ADO.NET
I have a simple stored procedure, it always returns NULL value,
but if I run it in the query anl. it'll work just fine. Can't figure it out... Any hint will be appreciated Thanks, Dean, if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[usp_GetTotalWeight]') and OBJECTPROPERTY(id, N'IsProcedure') = 1) drop procedure [dbo].[usp_GetTotalWeight] GO SET QUOTED_IDENTIFIER ON GO SET ANSI_NULLS ON GO create procedure usp_GetTotalWeight @OrderID int AS BEGIN set nocount on Select 44 as 'Weight' END GO SET QUOTED_IDENTIFIER OFF GO SET ANSI_NULLS ON GO /**********************************************************/ C# code: /**********************************************************/ System.Data.OleDb.OleDbDataReader objDataReader; Int64 curTotal=0; string[] ParamName = {"OrderID"}; System.Data.OleDb.OleDbType[] ParamType ={System.Data.OleDb.OleDbType.Integer}; string[] ParamValue={Convert.ToString(OrderID)}; objDataReader=GPC_obj_DataBase.fn_GetReader("usp_GetTotalWeight",ParamName,ParamType,ParamValue); int temp=objDataReader["Weight"] .... /**********************************************************/ public System.Data.OleDb.OleDbDataReader fn_GetReader(string strSQLStatement,string[] spParamName, System.Data.OleDb.OleDbType[] spParamType, string[] spParamValue) { if(GPC_obj_DataReader!=null) { GPC_obj_DataReader.Close(); } System.Data.OleDb.OleDbCommand GPC_obj_Command =new System.Data.OleDb.OleDbCommand(); GPC_obj_Command.CommandText = strSQLStatement; GPC_obj_Command.CommandType=CommandType.StoredProcedure; GPC_obj_Command.Connection = ActiveConnection; for (int i=0; i < spParamName.GetLength(0); i++) { GPC_obj_Command.Parameters.Add(spParamName[i],spParamType[i]); GPC_obj_Command.Parameters[i].Value=spParamValue[i]; } GPC_obj_DataReader= GPC_obj_Command.ExecuteReader(); return GPC_obj_DataReader;
Why are you using the OleDbDataReader instead of the SqlDataReader?
Have you tried using the GetInt32 method instead of using the objDataReader["Weight"]? int temp = objDataReader.GetInt32(0); Also, as a style note, you might consider getting rid of the 'obj' prefix -- Everything in .NET is an object. Repeating that fact in a variable name gives you no additional information; it just increases the amount of typing you need to do :) -- Adam Machanic SQL Server MVP http://www.sqljunkies.com/weblog/amachanic -- [quoted text, click to view] "DK" <konnyro@yahoo.com> wrote in message objDataReader=GPC_obj_DataBase.fn_GetReader("usp_GetTotalWeight",ParamName,Pnews:ab31dbe5.0411062242.40a2edfb@posting.google.com... > I have a simple stored procedure, it always returns NULL value, > but if I run it in the query anl. it'll work just fine. > Can't figure it out... > Any hint will be appreciated > > Thanks, > > Dean, > > if exists (select * from dbo.sysobjects where id = > object_id(N'[dbo].[usp_GetTotalWeight]') and OBJECTPROPERTY(id, > N'IsProcedure') = 1) > drop procedure [dbo].[usp_GetTotalWeight] > GO > SET QUOTED_IDENTIFIER ON > GO > SET ANSI_NULLS ON > GO > create procedure usp_GetTotalWeight @OrderID int > AS > BEGIN > set nocount on > Select 44 as 'Weight' > END > GO > SET QUOTED_IDENTIFIER OFF > GO > SET ANSI_NULLS ON > GO > > /**********************************************************/ > C# code: > /**********************************************************/ > > System.Data.OleDb.OleDbDataReader objDataReader; > Int64 curTotal=0; > string[] ParamName = {"OrderID"}; > System.Data.OleDb.OleDbType[] ParamType > ={System.Data.OleDb.OleDbType.Integer}; > string[] ParamValue={Convert.ToString(OrderID)}; > aramType,ParamValue); [quoted text, click to view] > > int temp=objDataReader["Weight"] > ... > > /**********************************************************/ > public System.Data.OleDb.OleDbDataReader fn_GetReader(string > strSQLStatement,string[] spParamName, System.Data.OleDb.OleDbType[] > spParamType, string[] spParamValue) > { > if(GPC_obj_DataReader!=null) > { > GPC_obj_DataReader.Close(); > } > System.Data.OleDb.OleDbCommand GPC_obj_Command =new > System.Data.OleDb.OleDbCommand(); > GPC_obj_Command.CommandText = strSQLStatement; > GPC_obj_Command.CommandType=CommandType.StoredProcedure; > GPC_obj_Command.Connection = ActiveConnection; > for (int i=0; i < spParamName.GetLength(0); i++) > { > GPC_obj_Command.Parameters.Add(spParamName[i],spParamType[i]); > GPC_obj_Command.Parameters[i].Value=spParamValue[i]; > } > > GPC_obj_DataReader= GPC_obj_Command.ExecuteReader(); > return GPC_obj_DataReader; > }
To add to Adam's response, it looks like your code is missing a call to the
data reader Read method. You might also consider using ExecuteScalar instead of ExecuteReader for a single-row single-column result. -- Hope this helps. Dan Guzman SQL Server MVP [quoted text, click to view] "DK" <konnyro@yahoo.com> wrote in message news:ab31dbe5.0411062242.40a2edfb@posting.google.com... >I have a simple stored procedure, it always returns NULL value, > but if I run it in the query anl. it'll work just fine. > Can't figure it out... > Any hint will be appreciated > > Thanks, > > Dean, > > if exists (select * from dbo.sysobjects where id = > object_id(N'[dbo].[usp_GetTotalWeight]') and OBJECTPROPERTY(id, > N'IsProcedure') = 1) > drop procedure [dbo].[usp_GetTotalWeight] > GO > SET QUOTED_IDENTIFIER ON > GO > SET ANSI_NULLS ON > GO > create procedure usp_GetTotalWeight @OrderID int > AS > BEGIN > set nocount on > Select 44 as 'Weight' > END > GO > SET QUOTED_IDENTIFIER OFF > GO > SET ANSI_NULLS ON > GO > > /**********************************************************/ > C# code: > /**********************************************************/ > > System.Data.OleDb.OleDbDataReader objDataReader; > Int64 curTotal=0; > string[] ParamName = {"OrderID"}; > System.Data.OleDb.OleDbType[] ParamType > ={System.Data.OleDb.OleDbType.Integer}; > string[] ParamValue={Convert.ToString(OrderID)}; > objDataReader=GPC_obj_DataBase.fn_GetReader("usp_GetTotalWeight",ParamName,ParamType,ParamValue); > > int temp=objDataReader["Weight"] > ... > > /**********************************************************/ > public System.Data.OleDb.OleDbDataReader fn_GetReader(string > strSQLStatement,string[] spParamName, System.Data.OleDb.OleDbType[] > spParamType, string[] spParamValue) > { > if(GPC_obj_DataReader!=null) > { > GPC_obj_DataReader.Close(); > } > System.Data.OleDb.OleDbCommand GPC_obj_Command =new > System.Data.OleDb.OleDbCommand(); > GPC_obj_Command.CommandText = strSQLStatement; > GPC_obj_Command.CommandType=CommandType.StoredProcedure; > GPC_obj_Command.Connection = ActiveConnection; > for (int i=0; i < spParamName.GetLength(0); i++) > { > GPC_obj_Command.Parameters.Add(spParamName[i],spParamType[i]); > GPC_obj_Command.Parameters[i].Value=spParamValue[i]; > } > > GPC_obj_DataReader= GPC_obj_Command.ExecuteReader(); > return GPC_obj_DataReader; > }
Thanks for the hints, i've tried to change it, still got nothing...
*** Sent via Developersdex http://www.developersdex.com ***
[quoted text, click to view]
> Thanks for the hints, i've tried to change it, still got nothing... Below is a working code snippet you might try. The code you originally posted is incomplete so I can't determine the underlying cause of the problem. try { int OrderID = 0; OleDbConnection connection = new OleDbConnection( "Provider=SQLOLEDB;" + "Server=MyServer;" + "Initial Catalog=MyDatabase;" + "Integrated Security=SSPI"); connection.Open(); OleDbCommand GPC_obj_Command = new OleDbCommand("usp_GetTotalWeight", connection); GPC_obj_Command.CommandType=CommandType.StoredProcedure; OleDbParameter orderIdParameter = new OleDbParameter( "OrderID", OleDbType.Integer); GPC_obj_Command.Parameters.Add(orderIdParameter); orderIdParameter.Value = OrderID; int temp = (int) GPC_obj_Command.ExecuteScalar(); Console.WriteLine(temp.ToString()); connection.Close(); } catch (OdbcException ex) { Console.WriteLine(ex.ToString()); } -- Hope this helps. Dan Guzman SQL Server MVP [quoted text, click to view] "Dean Kim" <konnyro@yahoo.com> wrote in message news:OC2UV%23QxEHA.3288@TK2MSFTNGP14.phx.gbl... > Thanks for the hints, i've tried to change it, still got nothing... > > > *** Sent via Developersdex http://www.developersdex.com *** > Don't just participate in USENET...get rewarded for it!
Don't see what you're looking for? Try a search.
|
January 2003
March 2003
April 2003
May 2003
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
April 2008
August 2008
| home · blog · groups | Questions? Comments? Contact the dn |