sql server programming: @@Error not behaving as expected. -- sql server programming

You're in the

sql server programming

group:

@@Error not behaving as expected.

Doogie
10/17/2007 11:21:16 PM

sql server programming:

Hello, I am running into a situation where inside one stored proc I
am executing another. If the 2nd proc errors, there is an update in
the first proc that I do NOT want to execute. So I have code like
this:

EXEC MyProcName @Parameter1, @Parameter2

IF (@@ERROR = 0)
BEGIN
UPDATE myTable
SET myColumn = myValue
WHERE someColumn = someValue
END

The problem is that if the proc being called errors, @@ERROR is still
returning 0. I can clearly see an error returned, but the update is
being executed.

In the proc that is being called, the error I'm running into is raised
like so:

RAISERROR (@ErrMsg, 16, 1)
RETURN

The only other thing I can think of is that the first proc is calling
the 2nd one via a linked server. Not sure if that is an issue or not
(if errors will travel over linked servers).

Any thoughts?

Re: @@Error not behaving as expected.

Uri Dimant
10/18/2007 12:00:00 AM

Hi
CREATE PROCEDURE MyProcName AS

BEGIN TRANSACTION

UPDATE Table1 .

SET @Err = @@ERROR
IF @Err <> 0
BEGIN
ROLLBACK TRANSACTION
RETURN (@Err)
END

--Usage

CREATE PROC spAnotherOne
AS
EXEC @Ret = MyProcName ----Returns 0 if everything is OK

IF @Ret = 0
BEGIN
UPDATE myTable
SET myColumn = myValue
WHERE someColumn = someValue
END

[quoted text, click to view]

Re: @@Error not behaving as expected.

Dan Guzman
10/18/2007 7:32:38 AM

In addition to using a return code as URI suggested, see
http://www.sommarskog.se/error-handling-II.html for a detailed error
handling discussion.

--
Hope this helps.

Dan Guzman
SQL Server MVP

[quoted text, click to view]

Re: @@Error not behaving as expected.

Doogie
10/20/2007 1:21:49 PM

[quoted text, click to view]

The problem actually turned out to be that we were using a linked
server call to execute that 2nd proc. Apparently @@Error doesn't
travel over the call. We did a modified version of what you
suggested, we created a 2nd proc on the same server as the proc we are
calling and called the proc we wanted to call from within that, and
returned @@ERROR from it as a return value. This worked. We didn't
want to modify the proc we were calling as it would have required
checking @@ERROR in many, many spots and would have been a substantial
change to the proc. This solution got us around that too.

Got something to say? Click here to post a reply to this thread.

Don't see what you're looking for? Try a search.

View other messages in the sql server programming group.

View Other Months
January 2003
March 2003
April 2003
May 2003
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
April 2008

home · blog · groups

Questions? Comments? Contact the dn