| Groups | Blog | Home |
dotnet compact framework : Forms not completely disposing...
Setup the project... Form1 that contains two buttons and an input panel. Form2 that contains one label and an input panel. Form2's constructor has an integer as an parameter. This will be the identifier when the form shows it status message. Everytime the input panel changes enable state the form will popup a messagebox with the id and the panel's state. Form1's buttons are exactly the same in that both will create a variable for Form2 then call the ShowDialog method. The difference is that one will call the dispose method after displaying the form. Setup the problem... When you click either button the Form2 will popup then you can click the OK button. Once you click the button to close the form the messagebox will popup and state "Form2 - 0: False". Close the messagebox. At this point I expect the Form2 variable to be dispose and irrelevant. Enter the problem... Now if you click Form1's input panel you will get a message from the Form2 that states "Form2 - 0: True". At this point you shouldn't be running any code in Form2... Code below... public partial class Form1 : Form { protected int count; public Form1() { InitializeComponent(); count = 0; } private void button1_Click(object sender, EventArgs e) { Form2 dlg = new Form2(count++); try { dlg.ShowDialog(); } finally { dlg.Dispose(); } } private void button2_Click(object sender, EventArgs e) { Form2 dlg = new Form2(count++); dlg.ShowDialog(); } } public partial class Form2 : Form { protected int _id; public Form2(int ID) { InitializeComponent(); _id = ID; label1.Text = "Form2: " + _id.ToString(); inputPanelForm2.Enabled = true; } private void inputPanelForm2_EnabledChanged(object sender, EventArgs e) { MessageBox.Show("Form2 - " + _id.ToString() + ": " + inputPanelForm2.Enabled.ToString()); } private void Form2_Closing(object sender, CancelEventArgs e) { inputPanelForm2.Enabled = false; } } -- Bobby Cannon
IIRC this is quite an old issue, basically, you need to remove any
events that you assign to an input panel control when closing/ disposing the form. Chris On May 15, 5:38 am, Bobby Cannon [quoted text, click to view] <BobbyCan...@discussions.microsoft.com> wrote: > Compact Framework 2 - SP2 > > Setup the project... > > Form1 that contains two buttons and an input panel. > Form2 that contains one label and an input panel. > > Form2's constructor has an integer as an parameter. This will be the > identifier when the form shows it status message. Everytime the input panel > changes enable state the form will popup a messagebox with the id and the > panel's state. > > Form1's buttons are exactly the same in that both will create a variable for > Form2 then call the ShowDialog method. The difference is that one will call > the dispose method after displaying the form. > > Setup the problem... > > When you click either button the Form2 will popup then you can click the OK > button. Once you click the button to close the form the messagebox will popup > and state "Form2 - 0: False". Close the messagebox. At this point I expect > the Form2 variable to be dispose and irrelevant. > > Enter the problem... > > Now if you click Form1's input panel you will get a message from the Form2 > that states "Form2 - 0: True". At this point you shouldn't be running any > code in Form2... > > Code below... > > public partial class Form1 : Form > { > protected int count; > > public Form1() > { > InitializeComponent(); > > count = 0; > } > > private void button1_Click(object sender, EventArgs e) > { > Form2 dlg = new Form2(count++); > > try > { > dlg.ShowDialog(); > } > finally > { > dlg.Dispose(); > } > } > > private void button2_Click(object sender, EventArgs e) > { > Form2 dlg = new Form2(count++); > dlg.ShowDialog(); > } > > } > > public partial class Form2 : Form > { > protected int _id; > > public Form2(int ID) > { > InitializeComponent(); > > _id = ID; > label1.Text = "Form2: " + _id.ToString(); > > inputPanelForm2.Enabled = true; > } > > private void inputPanelForm2_EnabledChanged(object sender, EventArgs > e) > { > MessageBox.Show("Form2 - " + _id.ToString() + ": " + > inputPanelForm2.Enabled.ToString()); > } > > private void Form2_Closing(object sender, CancelEventArgs e) > { > inputPanelForm2.Enabled = false; > } > } > > -- > Bobby Cannonwww.sharpdeck.net
It looks like that worked. I didn't expect to have to do this.
-- Bobby Cannon SharpDeck Software
On May 15, 12:38 am, Bobby Cannon
[quoted text, click to view] <BobbyCan...@discussions.microsoft.com> wrote: > Compact Framework 2 - SP2 > > Setup the project... > > Form1 that contains two buttons and an input panel. > Form2 that contains one label and an input panel. > > Form2's constructor has an integer as an parameter. This will be the > identifier when the form shows it status message. Everytime the input panel > changes enable state the form will popup a messagebox with the id and the > panel's state. > > Form1's buttons are exactly the same in that both will create a variable for > Form2 then call the ShowDialog method. The difference is that one will call > the dispose method after displaying the form. > > Setup the problem... > > When you click either button the Form2 will popup then you can click the OK > button. Once you click the button to close the form the messagebox will popup > and state "Form2 - 0: False". Close the messagebox. At this point I expect > the Form2 variable to be dispose and irrelevant. > > Enter the problem... > > Now if you click Form1's input panel you will get a message from the Form2 > that states "Form2 - 0: True". At this point you shouldn't be running any > code in Form2... > > Code below... > > public partial class Form1 : Form > { > protected int count; > > public Form1() > { > InitializeComponent(); > > count = 0; > } > > private void button1_Click(object sender, EventArgs e) > { > Form2 dlg = new Form2(count++); > > try > { > dlg.ShowDialog(); > } > finally > { > dlg.Dispose(); > } > } > > private void button2_Click(object sender, EventArgs e) > { > Form2 dlg = new Form2(count++); > dlg.ShowDialog(); > } > > } > > public partial class Form2 : Form > { > protected int _id; > > public Form2(int ID) > { > InitializeComponent(); > > _id = ID; > label1.Text = "Form2: " + _id.ToString(); > > inputPanelForm2.Enabled = true; > } > > private void inputPanelForm2_EnabledChanged(object sender, EventArgs > e) > { > MessageBox.Show("Form2 - " + _id.ToString() + ": " + > inputPanelForm2.Enabled.ToString()); > } > > private void Form2_Closing(object sender, CancelEventArgs e) > { > inputPanelForm2.Enabled = false; > } > } > > -- > Bobby Cannonwww.sharpdeck.net You need to explicitly call InputPanelForm2.Dispose in your Form2_Closing method. Calling Dispose() on a control (including forms) does not automatically call Dispose() on the contained components.
Is that just for InputPanel? or all controls... I was under the impression
that the framework did that? Does this apply to the full framework? -- Bobby Cannon www.sharpdeck.net [quoted text, click to view] "HedgehogJim@gmail.com" wrote:
> > You need to explicitly call InputPanelForm2.Dispose in your > Form2_Closing method. > > Calling Dispose() on a control (including forms) does not > automatically call Dispose() on the contained components. >
I understand but just looking at the MSDN how would I know to dispose of this
specific toolbox item? What other "controls" need to be manually disposed of? Is there a list? -- Bobby Cannon www.sharpdeck.net [quoted text, click to view] "<ctacke/>" wrote:
> The framework Disposes all Controls in the Form's Controls collection. > Components (like the InputPanel) and anything not in the Controls collection > must be manually Disposed. > > > -- > > Chris Tacke, Embedded MVP > OpenNETCF Consulting > Managed Code in an Embedded World > www.OpenNETCF.com
The framework Disposes all Controls in the Form's Controls collection.
Components (like the InputPanel) and anything not in the Controls collection must be manually Disposed. -- Chris Tacke, Embedded MVP OpenNETCF Consulting Managed Code in an Embedded World www.OpenNETCF.com [quoted text, click to view] "Bobby Cannon" <BobbyCannon@discussions.microsoft.com> wrote in message news:BB82EA62-262A-4885-A8B2-640B8A6E0FBD@microsoft.com... > Is that just for InputPanel? or all controls... I was under the impression > that the framework did that? Does this apply to the full framework? > -- > Bobby Cannon > www.sharpdeck.net > > > "HedgehogJim@gmail.com" wrote: > >> >> You need to explicitly call InputPanelForm2.Dispose in your >> Form2_Closing method. >> >> Calling Dispose() on a control (including forms) does not >> automatically call Dispose() on the contained components. >> >>
There's no "list" as there can't be - whether a Control needs to be disposed
manually or not depends on how it's used in the application. When a Form is disposed, the Controls collection is iterated and each item in it is Disposed. Components are never added to the Controls collection, so anything that is a Component must be manually disposed. If you create a Control, but don't add it to the Controls collection (maybe you use it as a sync root, maybe for marshaling Invoke calls, whatever) then it would need manual Disposal as well. -- Chris Tacke, Embedded MVP OpenNETCF Consulting Managed Code in an Embedded World www.OpenNETCF.com [quoted text, click to view] "Bobby Cannon" <BobbyCannon@discussions.microsoft.com> wrote in message news:A790F944-2B15-46A7-A49C-5E4BB0324E47@microsoft.com... >I understand but just looking at the MSDN how would I know to dispose of >this > specific toolbox item? What other "controls" need to be manually disposed > of? > Is there a list? > > -- > Bobby Cannon > www.sharpdeck.net > > > "<ctacke/>" wrote: > >> The framework Disposes all Controls in the Form's Controls collection. >> Components (like the InputPanel) and anything not in the Controls >> collection >> must be manually Disposed. >> >> >> -- >> >> Chris Tacke, Embedded MVP >> OpenNETCF Consulting >> Managed Code in an Embedded World >> www.OpenNETCF.com >>
Don't see what you're looking for? Try a search.
|
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
December 2007
January 2008
February 2008
March 2008
April 2008
May 2008
June 2008
| home · blog · groups | Questions? Comments? Contact the dn |