|
|
You're in the
dotnet interop
group:excel process not terminating properly
dotnet interop:
have isolated the problem to the code below. Objects are released and the process ends until I use "int k = sheet.Count;" Then the process does not end. So I feel confident the problem occurrs here. It appears another reference is created that needs to be closed. Can anyone tell me how to do this? :) Thank you Excel.Workbook workbook = (Excel.Workbook)excelapplication.ActiveWorkbook; Excel.Sheets sheet = workbook.Worksheets; // problem here int k = sheet.Count; System.Runtime.InteropServices.Marshal.ReleaseComObject(sheet); sheet = null; System.Runtime.InteropServices.Marshal.ReleaseComObject(workbook); workbook = null;
Try adding the following just BEFORE your call ReleaseCOMObject on them:
sheet = null; workbook = null; [quoted text, click to view] <chuckie_9497@hotmail.com> wrote in message news:1176917315.668226.159170@y80g2000hsf.googlegroups.com... > hello all you gurus. I am struggling with releasing com objects. I > have isolated the problem to the code below. Objects are released and > the process ends until I > use "int k = sheet.Count;" Then the process does not end. So I feel > confident the problem occurrs here. It appears another reference is > created that needs to be closed. Can anyone tell me how to do > this? :) > Thank you > > Excel.Workbook workbook = > (Excel.Workbook)excelapplication.ActiveWorkbook; > Excel.Sheets sheet = workbook.Worksheets; > > // problem here > int k = sheet.Count; > > System.Runtime.InteropServices.Marshal.ReleaseComObject(sheet); > sheet = null; > System.Runtime.InteropServices.Marshal.ReleaseComObject(workbook); > workbook = null; >
On Apr 18, 3:48 pm, "Herfried K. Wagner [MVP]" <hirf-spam-me-
[quoted text, click to view] h...@gmx.at> wrote: > <chuckie_9...@hotmail.com> schrieb: > > > I am struggling with releasing com objects. I > > have isolated the problem to the code below. Objects are released and > > the process ends until I > > use "int k = sheet.Count;" Then the process does not end. > > PRB: Office Application Does Not Quit After Automation from Visual Studio > .NET Client > <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> > -> "Troubleshooting" > > -- > M S Herfried K. Wagner > M V P <URL:http://dotnet.mvps.org/> > V B <URL:http://dotnet.mvps.org/dotnet/faqs/> thank you for your resposnse and I have to admit I am somewhat confused (I guess that's obvious). I read the article and maybe I missed the obvious, but I do use GC.Collect() and GC.WaitForPendingFinalizers() and excelapplication.quit(). And I think I understand that I must explicitly reference any object that is implicitly created. So, I think (I am probably wrong) int k = sheet.Count; creates an implicit reference that I must explicitly reference so I can remove the reference. Is this correct? If so , how do I do that? If I am wrong, please correct me. Everything works fine until this statement is added. Thank you
On Apr 18, 3:48 pm, "Herfried K. Wagner [MVP]" <hirf-spam-me-
[quoted text, click to view] h...@gmx.at> wrote: > <chuckie_9...@hotmail.com> schrieb: > > > I am struggling with releasing com objects. I > > have isolated the problem to the code below. Objects are released and > > the process ends until I > > use "int k = sheet.Count;" Then the process does not end. > > PRB: Office Application Does Not Quit After Automation from Visual Studio > .NET Client > <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> > -> "Troubleshooting" > > -- > M S Herfried K. Wagner > M V P <URL:http://dotnet.mvps.org/> > V B <URL:http://dotnet.mvps.org/dotnet/faqs/> thank you for your resposnse and I have to admit I am somewhat confused (I guess that's obvious). I read the article and maybe I missed the obvious, but I do use GC.Collect() and GC.WaitForPendingFinalizers() and excelapplication.quit(). And I think I understand that I must explicitly reference any object that is implicitly created. So, I think (I am probably wrong) int k = sheet.Count; creates an implicit reference that I must explicitly reference so I can remove the reference. Is this correct? If so , how do I do that? If I am wrong, please correct me. Everything works fine until this statement is added. Thank you
this is a scam
the problem is using DAO. screw DAO and you won't have this problem ADO works like a charm On Apr 18, 12:48 pm, "Herfried K. Wagner [MVP]" <hirf-spam-me- [quoted text, click to view] h...@gmx.at> wrote: > <chuckie_9...@hotmail.com> schrieb: > > > I am struggling with releasing com objects. I > > have isolated the problem to the code below. Objects are released and > > the process ends until I > > use "int k = sheet.Count;" Then the process does not end. > > PRB: Office Application Does Not Quit After Automation from Visual Studio > .NET Client > <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> > -> "Troubleshooting" > > -- > M S Herfried K. Wagner > M V P <URL:http://dotnet.mvps.org/> > V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
Your link shows (in a more elaborate way) how to do what the OP is already
doing (RleaseCOMObject and set to null). Is there a particular part of the article that you suggest? [quoted text, click to view] "Herfried K. Wagner [MVP]" <hirf-spam-me-here@gmx.at> wrote in message news:uFncFgfgHHA.4284@TK2MSFTNGP06.phx.gbl... > <chuckie_9497@hotmail.com> schrieb: >> I am struggling with releasing com objects. I >> have isolated the problem to the code below. Objects are released and >> the process ends until I >> use "int k = sheet.Count;" Then the process does not end. > > PRB: Office Application Does Not Quit After Automation from Visual Studio > .NET Client > <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> > -> "Troubleshooting" > > -- > M S Herfried K. Wagner > M V P <URL:http://dotnet.mvps.org/> > V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
On Apr 18, 5:38 pm, "Willy Denoyette [MVP]"
[quoted text, click to view] <willy.denoye...@telenet.be> wrote: > <chuckie_9...@hotmail.com> wrote in message > > news:1176929507.407777.288290@b58g2000hsg.googlegroups.com... > > > > > > > On Apr 18, 3:48 pm, "Herfried K. Wagner [MVP]" <hirf-spam-me- > > h...@gmx.at> wrote: > >> <chuckie_9...@hotmail.com> schrieb: > > >> > I am struggling with releasing com objects. I > >> > have isolated the problem to the code below. Objects are released and > >> > the process ends until I > >> > use "int k = sheet.Count;" Then the process does not end. > > >> PRB: Office Application Does Not Quit After Automation from Visual Studio > >> .NET Client > >> <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> > >> -> "Troubleshooting" > > >> -- > >> M S Herfried K. Wagner > >> M V P <URL:http://dotnet.mvps.org/> > >> V B <URL:http://dotnet.mvps.org/dotnet/faqs/> > > > thank you for your resposnse and I have to admit I am somewhat > > confused (I guess that's obvious). I read the article and maybe I > > missed the obvious, but I do use GC.Collect() and > > GC.WaitForPendingFinalizers() and excelapplication.quit(). And I > > think I understand that I must explicitly reference any object that is > > implicitly created. So, I think (I am probably wrong) int k = > > sheet.Count; creates an implicit reference that I must explicitly > > reference so I can remove the reference. Is this correct? If so , how > > do I do that? If I am wrong, please correct me. Everything works > > fine until this statement is added. Thank you > > No, Count does not create an reference to a COM object, sheet holds a reference to the COM > interface. > But as long as you don't post a *complete* sample, that illustrates the issue, you won't get > any sensible answers. > > A complete sample looks something like this: > > using System; > using System.Collections.Generic; > using System.Text; > using System.Globalization; > using System.Reflection; > > using Exl = Microsoft.Office.Interop.Excel; > namespace OffExc > { > class Program > { > [STAThread] > static void Main(string[] args) > { > System.Threading.Thread.CurrentThread.CurrentCulture = new CultureInfo( "en-US", > false ); > Exl.Application exApp = new Microsoft.Office.Interop.Excel.ApplicationClass(); > // Reference 1 > Exl.Workbook wb = exApp.Workbooks.Add(Missing.Value); // Reference 2 > exApp.Visible = true; > // Keep Excel visible for a while.. > System.Threading.Thread.Sleep(3000); > Exl.Sheets sheet = wb.Worksheets; // // Reference 3 > int k = sheet.Count; > // Quit > exApp.Quit(); > // Release the three COM references... > System.Runtime.InteropServices.Marshal.ReleaseComObject(sheet); > System.Runtime.InteropServices.Marshal.ReleaseComObject(wb); > System.Runtime.InteropServices.Marshal.ReleaseComObject(exApp); > GC.Collect(); > // Let the finalizer run, this one will delete the unmanaged COM wrappers, > // if for one or another reason, the finalizer cannot run to completion, > // chances are that the Excel process won't get removed !!!!!!!! > GC.WaitForPendingFinalizers(); > // Excel should be gone by now... keep the console processrunning for a while > System.Threading.Thread.Sleep(30000); > } > } > > } > > And above code works as expected on my box. > > Willy.- Hide quoted text - > > - Show quoted text - thank you gentlmen for your help. the following seems to be working correctly. of course I have alot more to do but this will get me started. Is there a "better" way to save the workbook (ie, use wb.saveas) and is there a better way way to enumerate and delete unwanted sheets? Also, I realize error checking needs to be implemented. Thanks again for your assistance. using System; using System.Reflection; using System.Threading; using System.Globalization; using Exl = Microsoft.Office.Interop.Excel; namespace mynamespace { class myexcel { public void test() { System.Threading.Thread.CurrentThread.CurrentCulture = new CultureInfo("en-US", false); Exl.Application exApp = new Microsoft.Office.Interop.Excel.ApplicationClass(); // Reference 1 Exl.Workbook wb = exApp.Workbooks.Add(Missing.Value); // Reference 2 exApp.Visible = true; Exl.Sheets sheet = wb.Worksheets; // Reference 3 // set active sheet Exl.Worksheet activesheet = (Exl.Worksheet)wb.ActiveSheet; activesheet.Name = "testsheet"; // write to cell A1 Exl.Range range; range = activesheet.get_Range("A1", Missing.Value); range.Value2 = "test input"; System.Runtime.InteropServices.Marshal.ReleaseComObject(range); // disable alerts so I'm not prompted when a worksheet is deleted exApp.DisplayAlerts = false; // delete a sheet for (int i = 1; i <= sheet.Count; i++) { // would like to delete Exl.Worksheet ob = (Exl.Worksheet)exApp.Worksheets[i]; if (ob.Name.ToLower().Substring(0, 5).Equals("sheet")) ob.Delete(); ReleaseComObject(ob); ob = null; } // save the workbook exApp.ActiveWorkbook.Close(true, @"c:\testxls.xls", Missing.Value); // Quit exApp.Quit(); // Release the COM references... ReleaseComObject(activesheet); ReleaseComObject(sheet); ReleaseComObject(wb); ReleaseComObject(exApp); GC.Collect(); // Let the finalizer run, this one will delete the unmanaged COM wrappers, // if for one or another reason, the finalizer cannot run to completion, // chances are that the Excel process won't get removed !!!!!!!! GC.WaitForPendingFinalizers(); // Excel should be gone by now... keep the console processrunning for a while System.Threading.Thread.Sleep(3000); } public void ReleaseComObject(Object reference) { try { while (System.Runtime.InteropServices.Marshal.ReleaseComObject(reference) > -1) ; } catch (Exception ex) { // handle exception } finally { reference = null; } } } }
By more elaborate, I just meant that they've broken the release of the
object into a separate function. It seems that the OP is doing the same thing in his code, just not in a separate function. What, exactly, is the article showing that the OP isn't doing? [quoted text, click to view] "Herfried K. Wagner [MVP]" <hirf-spam-me-here@gmx.at> wrote in message news:ON9olnfgHHA.2640@TK2MSFTNGP06.phx.gbl... > "Scott M." <s-mar@nospam.nospam> schrieb: >> Your link shows (in a more elaborate way) how to do what the OP is >> already doing (RleaseCOMObject and set to null). Is there a particular >> part of the article that you suggest? > > I suggest the "more elaborate way". > > -- > M S Herfried K. Wagner > M V P <URL:http://dotnet.mvps.org/> > V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
"Scott M." <s-mar@nospam.nospam> schrieb:
[quoted text, click to view] > Try adding the following just BEFORE your call ReleaseCOMObject on them: > > sheet = null; > workbook = null; Bad idea, because 'ReleaseComObject' won't release the objects if a null reference is passed to it. -- M S Herfried K. Wagner M V P <URL:http://dotnet.mvps.org/> V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
<chuckie_9497@hotmail.com> schrieb:
[quoted text, click to view] > I am struggling with releasing com objects. I > have isolated the problem to the code below. Objects are released and > the process ends until I > use "int k = sheet.Count;" Then the process does not end. PRB: Office Application Does Not Quit After Automation from Visual Studio ..NET Client <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> -> "Troubleshooting" -- M S Herfried K. Wagner M V P <URL:http://dotnet.mvps.org/>
"Scott M." <s-mar@nospam.nospam> schrieb:
[quoted text, click to view] > Your link shows (in a more elaborate way) how to do what the OP is already > doing (RleaseCOMObject and set to null). Is there a particular part of > the article that you suggest? I suggest the "more elaborate way". -- M S Herfried K. Wagner M V P <URL:http://dotnet.mvps.org/> V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
[quoted text, click to view]
<chuckie_9497@hotmail.com> wrote in message news:1176929507.407777.288290@b58g2000hsg.googlegroups.com... > On Apr 18, 3:48 pm, "Herfried K. Wagner [MVP]" <hirf-spam-me- > h...@gmx.at> wrote: >> <chuckie_9...@hotmail.com> schrieb: >> >> > I am struggling with releasing com objects. I >> > have isolated the problem to the code below. Objects are released and >> > the process ends until I >> > use "int k = sheet.Count;" Then the process does not end. >> >> PRB: Office Application Does Not Quit After Automation from Visual Studio >> .NET Client >> <URL:http://support.microsoft.com/?scid=kb;EN-US;317109> >> -> "Troubleshooting" >> >> -- >> M S Herfried K. Wagner >> M V P <URL:http://dotnet.mvps.org/> >> V B <URL:http://dotnet.mvps.org/dotnet/faqs/> > > thank you for your resposnse and I have to admit I am somewhat > confused (I guess that's obvious). I read the article and maybe I > missed the obvious, but I do use GC.Collect() and > GC.WaitForPendingFinalizers() and excelapplication.quit(). And I > think I understand that I must explicitly reference any object that is > implicitly created. So, I think (I am probably wrong) int k = > sheet.Count; creates an implicit reference that I must explicitly > reference so I can remove the reference. Is this correct? If so , how > do I do that? If I am wrong, please correct me. Everything works > fine until this statement is added. Thank you > No, Count does not create an reference to a COM object, sheet holds a reference to the COM interface. But as long as you don't post a *complete* sample, that illustrates the issue, you won't get any sensible answers. A complete sample looks something like this: using System; using System.Collections.Generic; using System.Text; using System.Globalization; using System.Reflection; using Exl = Microsoft.Office.Interop.Excel; namespace OffExc { class Program { [STAThread] static void Main(string[] args) { System.Threading.Thread.CurrentThread.CurrentCulture = new CultureInfo( "en-US", false ); Exl.Application exApp = new Microsoft.Office.Interop.Excel.ApplicationClass(); // Reference 1 Exl.Workbook wb = exApp.Workbooks.Add(Missing.Value); // Reference 2 exApp.Visible = true; // Keep Excel visible for a while.. System.Threading.Thread.Sleep(3000); Exl.Sheets sheet = wb.Worksheets; // // Reference 3 int k = sheet.Count; // Quit exApp.Quit(); // Release the three COM references... System.Runtime.InteropServices.Marshal.ReleaseComObject(sheet); System.Runtime.InteropServices.Marshal.ReleaseComObject(wb); System.Runtime.InteropServices.Marshal.ReleaseComObject(exApp); GC.Collect(); // Let the finalizer run, this one will delete the unmanaged COM wrappers, // if for one or another reason, the finalizer cannot run to completion, // chances are that the Excel process won't get removed !!!!!!!! GC.WaitForPendingFinalizers(); // Excel should be gone by now... keep the console processrunning for a while System.Threading.Thread.Sleep(30000); } } } And above code works as expected on my box. Willy.
"Scott M." <s-mar@nospam.nospam> schrieb:
[quoted text, click to view] > By more elaborate, I just meant that they've broken the release of the > object into a separate function. It seems that the OP is doing the same > thing in his code, just not in a separate function. What, exactly, is the > article showing that the OP isn't doing? Take a look at the information in the "Troubleshooting" section of the document. -- M S Herfried K. Wagner M V P <URL:http://dotnet.mvps.org/> V B <URL:http://dotnet.mvps.org/dotnet/faqs/>
Don't see what you're looking for? Try a search.
|
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
December 2007
January 2008
February 2008
March 2008
April 2008
May 2008
June 2008
| home · blog · groups | Questions? Comments? Contact the dn |