"Marcus" <marcus.silfver@koping.net> wrote in message
news:1141803863.427688.125220@j52g2000cwj.googlegroups.com...
>I have a couple of classes looking like this:
> ========================================
>
> [Serializable]
> public class AdminSettingsData
> {
> public string adminSettingsPath;
> public string adminSettingsFile;
> public string usersSettingsPath;
>
> public bool playersHaveToLogin;
>
> private TBusers[] users = new TBusers[100];
> private int userCount;
>
> public TBusers[] Users
> {
> get { return users; }
> set { users = value; }
> }
>
> public int UserCount
> {
> get {return userCount; }
> set {userCount = value; }
> }
> }
>
> [Serializable]
> public class TBusers
> {
> public string name;
> public string passwd;
> }
>
> In the constructor I do:
> =====================
>
> // this variable is passed to other forms in the app for
> // letting the administrator add
> // or remove entries of users
> adminData = new AdminSettingsData();
>
> for (int i = 0; i < 100; i++)
> {
> adminData.Users[i] = new TBusers();
> }
>
> I then initializes some name and passwords in TBusers and Serializes
> this with binaryFormatter to a file.
> When I later on Deserializes this file by the line:
> adminData = (AdminSettingsData)formatter.Deserialize(fs);
>
> I get the names and passwords from the file (I have only initialized 4
> of them ([0]-[3]).
> The problem is that after Deserialization when I want to add one more
> name and password to adminData.Users[4] then multiple entries (like
> adminData.Users[5] and adminData.Users[6]) are also filled with that
> name and password and likewise when I try nullify the entries 5 and 6,
> I also gets entry 4 nullified. It is like multiple entries in my array
> are referencing the same memory.
>
> If I initialize the entry adminData.Users[4] with name and password
> before the Deserialization then it behaves like expected (only
> adminData.Users[4] is touched).
>
>
> Question 1:
> ===========
> shouldn't
> private TBusers[] users = new TBusers[100];
> be enough to allocate my array. Why is the loop necessary?
> for (int i = 0; i < 100; i++)
> {
> adminData.Users[i] = new TBusers();
> }
>
>
> Question 2:
> ============
> Is it the binaryFormatter that compresses all the tailing null entries
> in adminData.Users array or what is happening here?
>
>
> I am new to c#. Any help would be greatly appreciated!
>

Marcus wrote:

> private TBusers[] users = new TBusers[100];

> public TBusers[] Users
> {
> get { return users; }
> set { users = value; }
> }

> public int UserCount
> {
> get {return userCount; }
> set {userCount = value; }
> }

> [Serializable]
> public class TBusers

> {
> public string name;
> public string passwd;
> }

> In the constructor I do:
> =====================
>
> // this variable is passed to other forms in the app for
> // letting the administrator add
> // or remove entries of users
> adminData = new AdminSettingsData();
>
> for (int i = 0; i < 100; i++)
> {
> adminData.Users[i] = new TBusers();
> }

> I get the names and passwords from the file (I have only initialized 4
> of them ([0]-[3]).
> The problem is that after Deserialization when I want to add one more
> name and password to adminData.Users[4] then multiple entries (like
> adminData.Users[5] and adminData.Users[6]) are also filled with that
> name and password and likewise when I try nullify the entries 5 and 6,
> I also gets entry 4 nullified. It is like multiple entries in my array
> are referencing the same memory.

> Question 1:
> ===========
> shouldn't
> private TBusers[] users = new TBusers[100];
> be enough to allocate my array. Why is the loop necessary?
> for (int i = 0; i < 100; i++)
> {
> adminData.Users[i] = new TBusers();
> }

> Question 2:
> ============
> Is it the binaryFormatter that compresses all the tailing null entries
> in adminData.Users array or what is happening here?

> I am new to c#. Any help would be greatly appreciated!

> Why are you providing get/set methods to your private data? you might as
> well declare it public instead

> Why doesn't the AdminSettingsData.AdminSettingsData initialize it's
> Users property itself, or accept it as an argument?

> A better name would be User, we are defining properties for each user here.

> The loop fills Users, with actual TBusers instances, not null. why would
> you want to do that?

> There are no null-entries. You just initialized each entry to a new TBusers

> Perhaps take a course on object-oriented programming?

Marcus wrote:

> Thanks for the help.
> Could work a bit on that attitude though...

>>Why are you providing get/set methods to your private data? you might as
>>well declare it public instead
>
> I am providing get/set methods because I am planning that I will
> eventually check data for constraints and other abuse within these
> get/set methods.

>>Why doesn't the AdminSettingsData.AdminSettingsData initialize it's
>>Users property itself, or accept it as an argument?
>
> It could do that, yes. Maybe I will eventually. My app is not 100%
> ready yet (or not even near) so there is still time. Right now
> AdminSettingsData is just a container class for data without any
> methods of its own.

>>The loop fills Users, with actual TBusers instances, not null. why would
>>you want to do that?
>
> To avoid exceptions when my program tries to access a field in a null
> object.

>>There are no null-entries. You just initialized each entry to a new TBusers
>
> OK, what I meant was the entries that contains objects which
> datamembers are null.