> I'd like to use a generic validation function that I pass the control
> name to and have an alert box come up and then select the text in the
> text box and return the focus to the textbox if not valid. It's not
> working correctly and I expect my syntax isn't quite right. Please
> check it out and let me know what I'm doing wrong. Thanks, John Holmes
>

"gilly3" <news@NOSPAMgilly3.com> wrote in message
news:Xns94A86298A2D5DnewsNOSPAMgilly3com@207.46.248.16...
> "John Holmes" <johnsh@co.skagit.wa.us> wrote in
> news:uRp93UsBEHA.1704@TK2MSFTNGP10.phx.gbl:
>
> > I'd like to use a generic validation function that I pass the control
> > name to and have an alert box come up and then select the text in the
> > text box and return the focus to the textbox if not valid. It's not
> > working correctly and I expect my syntax isn't quite right. Please
> > check it out and let me know what I'm doing wrong. Thanks, John Holmes
> >
>
> You have your object reference in quotes - this is incorrect. isNaN is
> evaluating a string instead of the value of your control.
>
> If you are passing in a string for control, construct your object
> reference like this:
>
> document.forms["Form1"].elements["control"]
>
> I'd plop that object reference in a variable and code your function like
> this:
>
> function validateNumeric(control)
> {
> var oControl = document.forms["Form1"].elements["control"];
> if(isNaN(oControl.value))
> {
> alert("This field represents a money value and must be numeric.");
> oControl.focus();
> oControl.select();
> }
> }
>
> good luck
>
> -ivan.

> This looks like it should work except for the quotes around the passed
> parameter variable "control", won't it take that as a string literal
> and not a variable?
>
> I've tried without the quotes and with the quotes and I continue to
> get errors. I am confused on how to reference variables correctly in
> this model. Thanks, john
>

"gilly3" <news@NOSPAMgilly3.com> wrote in message
news:Xns94A86E27AA02DnewsNOSPAMgilly3com@207.46.248.16...
> "John Holmes" <johnsh@co.skagit.wa.us> wrote in
> news:OzmGN7sBEHA.3804@TK2MSFTNGP09.phx.gbl:
>
> > This looks like it should work except for the quotes around the passed
> > parameter variable "control", won't it take that as a string literal
> > and not a variable?
> >
> > I've tried without the quotes and with the quotes and I continue to
> > get errors. I am confused on how to reference variables correctly in
> > this model. Thanks, john
> >
>
> Whoops! Heh. Good catch. Yes, that should be
>
> document.forms["Form1"].elements[control]
>
> You say you've tried it like that and still are having trouble? The
> control parameter should be a string (literal or variable) that contains
> the name of the form element you want to validate. So, this should work
> with your function:
>
> <form name="Form1">
> <input name="Field1">
> <button onclick="validateNumeric('Field1');">Validate</button>
> </form>
>
> -ivan.

bruce barker wrote:
> its simpler and cleaner if you just pass the control:
>
> <form name="Form1">
> <input name="Field1">
> <button onclick="validateNumeric(this);">Validate</button>
> </form>
>
> <script>
> function validateNumeric(oControl)
> {
> if(isNaN(oControl.value))
> {
> alert("This field represents a money value and must be numeric.");
> oControl.focus();
> oControl.select();
> }
> }
> </script>

"Randy Webb" <hikksnotathome@aol.com> wrote in message
news:_u6dnc-ujb1p1Mzd4p2dnA@comcast.com...
> bruce barker wrote:
> > its simpler and cleaner if you just pass the control:
> >
> > <form name="Form1">
> > <input name="Field1">
> > <button onclick="validateNumeric(this);">Validate</button>
> > </form>
> >
> > <script>
> > function validateNumeric(oControl)
> > {
> > if(isNaN(oControl.value))
> > {
> > alert("This field represents a money value and must be
numeric.");
> > oControl.focus();
> > oControl.select();
> > }
> > }
> > </script>
>
> "this", in that context, refers to the button, not the input. So the
> function is checking to see if the buttons value is a number, if its not
> then you get the alert.
>
>
> --
> Randy
> Chance Favors The Prepared Mind
> comp.lang.javascript FAQ - http://jibbering.com/faq/

"bruce barker" wrote:
>
> its simpler and cleaner if you just pass the control:
>
> <form name="Form1">
> <input name="Field1">
> <button onclick="validateNumeric(this);">Validate</button>
> </form>