Design advice -- inetserver asp general

inetserver asp general : Design advice

dthmtlgod
4/28/2005 12:00:00 AM

Getting very close to getting this to work. I am getting a Type Mismatch
Error, if I select a valid problem, works great if I select a problem not
listed.

Dim ArrP(3) '=Problems
arrP(1) = "TOWER"
arrP(2) = "MONITOR"
arrP(3) = "KEYBOARD"

Dim booP
booP = False

Dim intP
Dim strP

Dim arrQ(3) '=Questions
arrQ(1) = "Is it broke?"
arrQ(2) = "Type of hardware?"
arrQ(3) = "Any other info?"

Dim arrX(3) '=Problem/Questions
arrX(1) = "1,2,3"
arrX(2) = "2,3"
arrX(3) = "1,3"

Dim arrY
Dim intY
Dim strY

Dim Problem
Problem = request.form("cmdProblem")

For intP = 1 to UBound(arrP)
if arrP(intP) = Problem then
booP = true
exit for
end if
next

if booP then
arrY = Split(arrX(inpP), ", ")
strY = "Please answer the following questions about your '"

**** Getting it on this line
strY = strY & arrP(Problem) & "' problem: " & vbCrLF
*****
for intY = 0 to UnBound(arrY)
strY = strY & vbCrLF & arrQ(arrY(intY))
next
Response.write (strY)
else
response.write ("Invalid Problem (" & Problem & ")")
end if

%>

[quoted text, click to view]

dthmtlgod
4/28/2005 12:00:00 AM

Typos on my part mostly. I think I have it where it is workable. Thank you
again for your script.

[quoted text, click to view]

dthmtlgod
4/28/2005 12:00:00 AM

It is asking the questions as it should, it is not displaying the problem
though. Still getting a type mismatch error. Any ideas?

Dim ArrP(3) '=Problems
arrP(1) = "TOWER"
arrP(2) = "MONITOR"
arrP(3) = "KEYBOARD"

strY = "Please answer the following questions about your '"
**** Getting it on this line
strY = strY & arrP(Problem) & "' problem: " & vbCrLF
****

dthmtlgod
4/28/2005 8:07:46 AM

I am creating a online help desk for my office. I am attempting to cleanup
my code and I was hoping for a little advice.

I have 30 different categories of requests ranging from the desktop issues
to application issues. I am using submit buttons on one version and a
dropdown/list box on the other. Both work the same.

All the items have the same name "cmdProblem". The value is then passed to
another form. This all works great.

I then have 30 "if" statements that ask a series of questions. A lot of
them ask the same questions, a few differ though. There is 1,800 lines of
code. Is there an easier way to do this?

PT = request.form("cmdProblem")

<% if ucase(pt) = "MONITOR" then %>

..... Code ....

I do this 30 times.

McKirahan
4/28/2005 8:13:49 AM

[quoted text, click to view]

If I understand the issue ...

You could have a matrix defining which problem asks which questions;
then, for the given Problem, ask the associated questions. For example:

Dim arrP(30) '= Problems
arrP(1) = "Monitor"
arrP(2) = "Keyboard"
...
Dim booP
booP = False
Dim intP
Dim strP

Dim arrQ(10) '= Questions
arrQ(1) = "Size?"
arrQ(2) = "Resolution?"
arrQ(3) = "O/S?"
...

Dim arrX(20) '= Problem / Question Matrix
arrX(1) = "1,2"
...

Dim arrY
Dim intY
Dim strY

Dim Problem
Problem = Request.Form("Problem")

For intP = 1 To UBound(arrP)
If arrP(intP) = Problem Then
booP = True
Exit For
End If
Next

If booP Then
arrY = Split(arrX(intP),",")
strY = "Please answer the following questions about your '"
strY = strY & arrp(Problem) & "' problem:" & vbCrLf
For intY = 0 To UBound(arrY)
strY = strY & vbCrLf & arrQ(arrY(intY))
Next
Response.Write(strY)
Else
Response.Write("Invalid Problem! (" & Problem & ")")
End If

[ P.S. I know arrays are zero-based.]

McKirahan
4/28/2005 9:32:02 AM

[quoted text, click to view]

I use hungarian notation (sort of) for variable name prefixes:

obj = object
int = integer (well, numeric anyway)
str = string
boo = boolean (i.e. True/False)

booP (if True) indicates that the Problem was found in arrP().

dthmtlgod
4/28/2005 10:16:21 AM

Wow, thank you for this, I will give it a try. I should be able to figure
this out. I am horrible with arrays though.

What does the booP variable accomplish?

[quoted text, click to view]

dthmtlgod
4/28/2005 10:53:43 AM

Thanks, make sense now.

[quoted text, click to view]

Got something to say? Click here to post a reply to this thread.

Don't see what you're looking for? Try a search.

View other messages about inetserver asp general

View Other Months
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007

home · blog · groups

Questions? Comments? Contact the dn