sql server (alternate): Best SQL possible -- sql server (alternate)

You're in the

sql server (alternate)

group:

Best SQL possible

bbigler NO[at]SPAM yahoo.com
3/19/2004 3:04:44 PM

sql server (alternate): By using Access as a front end to SQL server, I finally came up with a
statement that works (I think!?), but it doesn't seem elegant. Can
anyone help with a better one?

--Brent

======================================

Table1
AccountNumber
Shares
CUSIP

Table2
AccountNumber
Shares
SecurityID

Table3
SecurityID
CUSIP

I need to update the shares in Table2 (from Table1) where a) the
AccountNumber in Table2 matches Table1, and b) the CUSIP in Table1
matches the CUSIP in Table3.

Here's what I ended up with:

Update Table2 SET Table2.Shares = Table1.Shares FROM Table1 INNER JOIN
Table3 ON Table1.CUSIP = Table3.CUSIP INNER JOIN Table2 ON
Table3.SecurityID = Table2.SecurityID AND Table1.AccountNumber =
Table2.AccountNumber

The statement returns extra accounts sometimes -- maybe it's a bad

Re: Best SQL possible

David Portas
3/20/2004 9:24:32 AM

Here's an alternative (standard and "safer") way to write your UPDATE
statement but without proper tables structures or sample data I have no way
of testing if this will do what you require. If this code gives you the
error "Subquery returned more than 1 value" then probably the statement you
posted won't work the way you expect either.

UPDATE Table2
SET shares =
(SELECT T1.shares
FROM Table1 AS T1
JOIN Table3 AS T3
ON T1.cusip = T3.cusip
AND T1.accountnumber = Table2.accountnumber
AND T3.securityid = Table2.securityid)

What does "returns extra accounts" mean? If you need more help, please post
DDL (CREATE TABLE statements including primary and foreign keys and
constraints) and post a few rows of sample data as INSERT statements.

--
David Portas
SQL Server MVP
--

Re: Best SQL possible

John Bell
3/25/2004 11:22:53 PM

Hi

It is better to post the DDL (CREATE TABLE statements etc) rather than
pseudo-schemas along with example data (as insert statements). That way any
ambiguities are avoided. Without knowing the data it is hard to comment,
but I would try not to swap between CUSID and AccountNumber.

John

[quoted text, click to view]

Got something to say? Click here to post a reply to this thread.

Don't see what you're looking for? Try a search.

View other messages in the sql server (alternate) group.

View Other Months
January 2003
June 2003
July 2003
August 2003
September 2003
October 2003
November 2003
December 2003
January 2004
February 2004
March 2004
April 2004
May 2004
June 2004
July 2004
August 2004
September 2004
October 2004
November 2004
December 2004
January 2005
February 2005
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007

home · blog · groups

Questions? Comments? Contact the dn